4.7 KiB
4.7 KiB
1. Legacy Orchestration Closure Removal
- 1.1 Delete
VerifierInputHook,VerifierContextHolder,ToolTraceSummaryService, andToolTraceSummaryServiceTestas one proven-unused closure. - 1.2 Run whole-repository definition/import/instantiation/type-use searches proving no executable production/test source depends on the removed types; allow only negative guard strings.
- 1.3 Run Executor parser, Gatekeeper service/node, VerifiedInput, Verifier, Composer, Fallback, Chat integration, and test compilation regressions after deletion.
- 1.4 Confirm no Graph/shared protocol component or Spring bean required by the current path was removed.
2. Current Architecture And Eval Documentation
- 2.1 Update architecture index and
agent-orchestration.mdto explicit bounded StateGraph, verified-only Verifier input, conditional retry/Fallback, and orchestration trace. - 2.2 Update
session-trace-lifecycle.mdandcurrent-mvp-architecture.mdfor StateGraph Run lifecycle,orchestration_trace, explicit Gatekeeper Node, and new test layers. - 2.3 Update current evidence-pipeline/quality-gate/feedback/retrieval docs so full
tool_trace_summaryis historical compatibility rather than new Verifier input. - 2.4 Update
mvp/eval/README.mdregression commands and architecture descriptions to the authoritative Graph suite. - 2.5 Run a current-doc source scan proving no current truth document describes Chat as SequentialAgent/Hook Gatekeeper/full-trace Verifier.
3. Demo Orchestration Trace Contract
- 3.1 Extend
run-interview-demo-check.ps1to fail fast when exactrun.orchestrationTraceor required routing fields are missing. - 3.2 Add final node, termination reason, degraded, transition count, and evidence retry count to interview summary output.
- 3.3 Update demo README and trace checklist with exact run orchestration trace fields and responsibility separation.
- 3.4 Add/extend static script contract tests for exact runId use, orchestration assertion, and summary fields without requiring a live service.
4. Final Deterministic Regression
- 4.1 Run authoritative Workflow/Node Contract/Chat Integration and all focused Graph/Trace/Gatekeeper/Composer/Controller/Repository tests.
- 4.2 Run fixed
DiagnosisTraceEvaluatorTestandDiagnosisEvalBaselineDiffTest; confirm baseline count/distribution and no unexpected diff. - 4.3 Run Maven test compilation and any docs/script contract tests touched by cleanup.
- 4.4 Run current change strict validation, all main specs strict validation,
git diff --check, legacy-source scan, current-doc scan, and no-unexpected-schema check.
5. Maven Live E2E Startup And Requests
- 5.1 Confirm port 9900 is free, record pre-start log lengths/timestamps, and create a unique
iss-011-stage5-<timestamp>sessionId. - 5.2 Start Maven
spring-boot:runwith themvp-demoprofile as a hidden tracked background process and wait for readiness with bounded polling. - 5.3 Run the interview demo check into a target-only output directory and capture Chat/Trace/feedback/summary for the exact returned runId.
- 5.4 Assert live response success, non-empty answer, exact runId, Graph summary fields, Agent/tool evidence, evaluation audit, and useful feedback.
6. Live Logs And Database Evidence
- 6.1 Read only the new stage-5 application/chat/error log segments and correlate the current sessionId/runId/Graph lifecycle.
- 6.2 Classify every ERROR in the new segment; leave no unexplained error in accepted evidence.
- 6.3 Use
scripts/query_mysql.pyto prove V012 column existence and exact Run CHAT/SUCCESS/answer/metrics/self-evaluation/orchestration trace/feedback fields. - 6.4 Query JSON routing fields and compare version/final node/termination/degraded/evidence retry count with the exact Trace response.
- 6.5 Query AgentStep/ToolInvocation counts and distinct session/run ownership; prove wrong-session/run rows are zero.
7. Cleanup, Issue Closure And Handoff
- 7.1 Stop only the Maven/Java processes started by stage 5 and confirm port 9900 is released even on failure.
- 7.2 Remove target-only E2E output/startup files after extracting durable acceptance evidence.
- 7.3 Update ISS-011 final checklist/status and move it from
mvp/issues/activetomvp/issues/archivedonly after every gate passes. - 7.4 Update
mvp/issues/README.mdand current documentation links/status for archived ISS-011. - 7.5 Record deterministic, live E2E, log, database, process cleanup, known limits, and exact identities in devflow acceptance/evidence.
- 7.6 Run final OpenSpec/static/worktree scope checks and prepare stage 5 Archive/independent Git commit without pushing.