SuperBizAgent-java/openspec/changes/archive/2026-07-17-chat-diagnosis-stategraph-test-suite/tasks.md

1. Authoritative Test Layer Renames

• 1.1 Rename DiagnosisGraphRoutingTest to DiagnosisGraphWorkflowTest with Git history preserved and no assertion loss.
• 1.2 Rename DiagnosisRealGraphIntegrationTest to DiagnosisGraphNodeContractTest with existing real-node assertions preserved.
• 1.3 Run the two renamed classes alone and prove the rename baseline is green before adding coverage.

2. Workflow Coverage Matrix

• 2.1 Audit Workflow methods against every stage-4 Planner, Executor, Gatekeeper, Verifier, evidence-retry, Composer, and termination scenario.
• 2.2 Add explicit ceiling-driven LOW_CONFID and second-LOW_CONFID no-more-retry assertions where current routing coverage is only implicit.
• 2.3 Assert all unsafe pre-verification paths skip Verifier and every terminal path emits only its actual ordered events.
• 2.4 Keep ScriptedDiagnosisGraphActions as the only scripted workflow fixture and avoid duplicate Graph topology/factory setup.

3. Node Contract Coverage Matrix

• 3.1 Add a legal tool-failure/no-evidence Executor snapshot case proving COMPLETED continues to Gatekeeper.
• 3.2 Strengthen Gatekeeper REJECT with partial passed binding and prove pre-verification Fallback exposes no Executor claim.
• 3.3 Add Verifier invalid/failure contract assertions proving execution status is set without model/effective verdict fabrication.
• 3.4 Preserve current config identity, checked-binding projection, LOW_CONFID ceiling, full-snapshot revalidation, and Composer safe-material assertions.
• 3.5 Run all focused Adapter, Gatekeeper, VerifiedInput, protocol parser, retry preparer, and Fallback tests.

4. Chat Integration And Legacy Test Retirement

• 4.1 Confirm ChatServiceGraphIntegrationTest covers compatible ChatResult, SUCCESS/Fallback/FAILED, metrics/Eval, self-evaluation/trace, cleanup, and multi-run isolation.
• 4.2 Delete VerifierInputHookTest without changing production Hook/ThreadLocal types in stage 4.
• 4.3 Run replacement parser, Gatekeeper service/node, VerifiedInput, no-evidence, REJECT, Composer safety, Controller, Trace, Repository, and Eval regressions.
• 4.4 Add a source/test inventory check proving the three authoritative classes exist and Sequential/Hook implementation tests do not.

5. Verification And Handoff

• 5.1 Run the complete new Graph Workflow/Node Contract/Chat Integration suite and record exact test counts.
• 5.2 Run Maven test compilation and all retained public/security contract tests touched by the migration.
• 5.3 Run current change strict validation, all main specs strict validation, git diff --check, and prove src/main has no stage-4 diff.
• 5.4 Record the Issue requirement-to-test coverage matrix and any intentional overlap/known limits in devflow acceptance evidence.
• 5.5 Record that Maven live E2E, logs/, and scripts/query_mysql.py verification were not run and remain reserved for stage 5.