From 78039eff4733628a16b2042b489e605f0f65ea79 Mon Sep 17 00:00:00 2001
From: wdm <wdm@wdmdeMacBook-Air.local>
Date: Sun, 29 Mar 2026 01:20:21 +0800
Subject: [PATCH] Document drop rule constraint: stop_on_match must be true

Add explicit authoring constraint in filter-rule-engine-usage.md:
all drop rules must set stop_on_match=true to prevent low-priority
drop rules from overriding high-priority keep decisions.
---
 CODE_REVIEW.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CODE_REVIEW.md b/CODE_REVIEW.md
index 4a06cd0..2c0f69a 100644
--- a/CODE_REVIEW.md
+++ b/CODE_REVIEW.md
@@ -4,7 +4,7 @@
 
 - [x] `server.py` context 通过临时文件传递绕路 — `run_freshrss_pipeline` 改为同时接受 `dict | Path` 类型的 context，消除 `NamedTemporaryFile` 绕路（已修复）
 - [ ] `_load_required_env` 报错信息不区分"未传参数"还是"环境变量未设"，改善调试体验
-- [ ] `evaluate_filter_rules` 决策逻辑歧义 — `stop_on_match=True` 命中后应直接以该规则 decision 为最终结果，而非继续聚合所有 matched
+- [x] `evaluate_filter_rules` 决策逻辑歧义 — `stop_on_match=True` 命中后应直接以该规则 decision 为最终结果，而非继续聚合所有 matched（已确认：当前规则集安全，在 filter-rule-engine-usage.md 补充了 drop 规则必须设 stop_on_match=true 的约束说明）
 
 ## 重构建议（中等成本）