49 lines
1.7 KiB
Markdown
49 lines
1.7 KiB
Markdown
# Acceptance: executor-gatekeeper-hook
|
|
|
|
## Implementation Result
|
|
|
|
Completed stage two of Executor Structured Output V2.
|
|
|
|
- Added `ExecutorGatekeeperService`.
|
|
- Added initial `schema.executor_v2` and `evidence.invocation_ref` rules.
|
|
- Added `gatekeeper_result` to Verifier payload.
|
|
- Stored `gatekeeper_result` in `VerifierContextHolder`.
|
|
- Persisted `gatekeeper_result` under `diagnosis_session.self_evaluation.verifier_evaluation`.
|
|
- Updated Verifier prompt so Gatekeeper fail must not produce PASS.
|
|
- Added focused tests for schema failure, valid pass, fabricated invocation ids, tool name mismatch, hook payload, and persistence.
|
|
|
|
## Static Verification
|
|
|
|
- `cmd /c openspec validate executor-gatekeeper-hook`
|
|
- Result: passed.
|
|
- Coverage: OpenSpec change validity.
|
|
|
|
## Script Verification
|
|
|
|
- `mvn "-Dtest=ExecutorGatekeeperServiceTest,VerifierInputHookTest,ChatServiceSequentialAgentTest" test`
|
|
- Result: passed.
|
|
- Coverage: 23 focused tests for Gatekeeper service, hook integration, and ChatService persistence.
|
|
|
|
## Browser / Manual Verification
|
|
|
|
Not run. This stage changes backend validation and audit behavior only.
|
|
|
|
## Unverified
|
|
|
|
- Full live application run with a real LLM.
|
|
- MySQL trace inspection after a real chat session.
|
|
- Excerpt similarity or phrase/utilization rules.
|
|
|
|
Reason: This phase intentionally covers deterministic schema and invocation-reference validation. Full live verification is better after Verifier V2 and Composer are implemented.
|
|
|
|
## Remaining Work
|
|
|
|
- Phase three: Verifier V2 `claim_checks`.
|
|
- Phase four: Composer final-answer generation.
|
|
- Phase five: eval fixtures and full audit closure.
|
|
|
|
## Archive Status
|
|
|
|
Devflow archive files created for stage two. OpenSpec archive is expected before moving to stage three.
|
|
|